Fix #10321 to avoid multiple warnings about skipped deployment due to missing / unsupported environment #10438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joakime
requested changes
Aug 30, 2023
There was a problem hiding this comment.
I see this as a partial fix.
Yes, having this warning show up multiple times is a mistake.
But the purpose of the warning should still be present, somehow, perhaps in the right place.
Example scenario:
- Jetty Base created with
--add-module=deploy(or justcore-deploy, but notee10-deploy) - A EE10 war file is copied into
${jetty.base}/webapps/ - Start Jetty.
That warning is the only thing telling the user that this webapp cannot be deployed, because there is no environment for it.
We still need that warning, but in the right place.
Without that warning the deploy silently fails.
joakime
changed the title
|
Closing this as the warning it is better to keep the warning in the common case of deploying 1 webapp with the wrong deployer. |
|
Not that it is not just duplicates, but false positives. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The warning message was causing confusion in case of multiple deployers. See also #10437.