Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Servlet 6.1 Cookie fixes #11935

Closed
wants to merge 4 commits into from

Conversation

gregw
Copy link
Contributor

@gregw gregw commented Jun 20, 2024

Support a violation to include the quotes as part of the value.
Never send a set-cookie with 0 max-age
Treat any non null non "false" attribute value as true
Don't set equals sign for attributes with empty value

gregw added 4 commits June 20, 2024 18:11
Added compliance mode MAINTAIN_QUOTES to keep the quotes as part of the cookie value.  Added mode RFC6265_QUOTED that includes this violation
Never send a zero valued max-age parameter
Partitioned is set if any attribute that is not "false" is set.
Partitioned is set if any attribute that is not "false" is set.
Avoid equal sign for empty valued attributes
@gregw gregw changed the title Assorted fixes for cookies in servlet 6.1 Servlet 6.1 Cookie fixes Jun 20, 2024
@gregw gregw requested review from janbartel and joakime June 20, 2024 08:32
@gregw gregw added Specification For all industry Specifications (IETF / Servlet / etc) TCK For various Specification Test Compatibility Kits (eg: Servlet, WebSocket, HTTP/2, etc) labels Jun 20, 2024
@gregw gregw closed this Jun 20, 2024
@gregw
Copy link
Contributor Author

gregw commented Jun 20, 2024

wrong branch

@gregw gregw deleted the fix/jetty-12.0.x/11934/quotedCookieValue branch June 20, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Specification For all industry Specifications (IETF / Servlet / etc) TCK For various Specification Test Compatibility Kits (eg: Servlet, WebSocket, HTTP/2, etc)
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

1 participant