Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/should-fall-through #11

Merged
merged 6 commits into from
May 2, 2017

Conversation

TeoTN
Copy link
Contributor

@TeoTN TeoTN commented Apr 1, 2017

Implement #10 - optional fall through pattern matching

README.md Outdated
@@ -51,6 +54,10 @@ const createBrowserHistory = rsr.createBrowserHistory;

const history = createBrowserHistory();

const options = {
shouldFallThrough: true,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

matchAll

README.md Outdated

Key | Description
--------------------|--------------------------------------------------------
`shouldFallThrough` | Determines whether route matching should take into account all matching rules
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

matchAll

@jfairbank
Copy link
Owner

Hi, @TeoTN. I commented on two fixes in the docs.

Also, can you bring this PR current with master and fix any merge conflicts. I appreciate that you put all the changes in #13, but I'd prefer to have separate PRs. If you can fix this PR, then I'm ready to merge :)

@jfairbank jfairbank mentioned this pull request Apr 26, 2017
@TeoTN
Copy link
Contributor Author

TeoTN commented Apr 28, 2017

I have updated README.md and merged with master - I hope that it suits you and will be released soon :) Thanks for your help!

@jfairbank jfairbank merged commit 1e3044d into jfairbank:master May 2, 2017
@jfairbank
Copy link
Owner

Thanks, @TeoTN!

I'll try to get a release out in a day or two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants