Updated README to mention React Router v4 support. #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @visusnet. That's great to hear! I haven't kept up a ton with RR4, but I'm guessing the setup would be slightly different with redux-saga-router? Can you also update the README with an example that uses RR4? |
|
I will add one tomorrow, no problem! :) |
|
@jfairbank I have updated the existing examples. I don't think a dedicated example for v4 is necessary since there are only a few changes necessary (imports, history object creation). |
|
That works @visusnet. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since v4 is supported but not officially mentioned and some people (incl. my team and others in #14) have tested the compatibility, this PR updates the README to incorporate v4.