Upgrade to redux-saga 1.0.2 #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New redux-saga 1.0.0 introduced some breaking changes, which changed the path for the effects used. This commit updates that path and some other related modules: - React, react-dom, react-router, redux, redux-saga, redux-saga-test-plan (beta, as is the only version supporting 1.0.0) - Update redux-saga-test-plan for working version, but still in PR
luistorres
commented
Jan 29, 2019
|
|
||
| // eslint-disable-next-line import/namespace | ||
| export const all = sagaEffects.all || (effects => effects); |
|
CI is failing atm, because |
Update redux-saga to v1.0.1
|
@jfairbank I know you're busy atm, but any chance you can merge this? With the latest beta of |
|
Is this PR going to be merged soon? |
|
Hey @jfairbank could you please consider merging that PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
path for the effects used.
This change addresses the issue by:
redux-saga-test-plan (Beta 2, as is the only version correctly supporting redux-saga 1.0.0)