Merge pull request #15 from jfrconley/joco/hotfix-error-content-type

fix parse error content type
jfrconley · Dec 1, 2023 · be4f584 · be4f584
2 parents 1cb8832 + 668528f
commit be4f584
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 8 deletions.
diff --git a/packages/rest/__tests__/src/parse.spec.mts b/packages/rest/__tests__/src/parse.spec.mts
@@ -1,4 +1,4 @@
-import {httpEventParser, NornirParseError, UnparsedHttpEvent} from "../../dist/runtime/index.mjs";
+import {httpEventParser, NornirRestParseError, UnparsedHttpEvent} from "../../dist/runtime/index.mjs";
 
 describe("Parsing", () => {
     it("Should throw correct error on failure to parse", () => {
@@ -14,6 +14,6 @@ describe("Parsing", () => {
             rawQuery: ""
         }
 
-        expect(() => parser(event)).toThrow(NornirParseError)
+        expect(() => parser(event)).toThrow(NornirRestParseError)
     })
 })
diff --git a/packages/rest/src/runtime/index.mts b/packages/rest/src/runtime/index.mts
@@ -12,7 +12,7 @@ export {
 export {RouteHolder, NornirRestRequestValidationError} from './route-holder.mjs'
 export {NornirRestRequestError, NornirRestError, httpErrorHandler, mapError, mapErrorClass} from './error.mjs'
 export {ApiGatewayProxyV2, startLocalServer} from "./converters.mjs"
-export {httpEventParser, HttpBodyParser, HttpBodyParserMap, HttpQueryStringParser, NornirParseError} from "./parse.mjs"
+export {httpEventParser, HttpBodyParser, HttpBodyParserMap, HttpQueryStringParser, NornirRestParseError} from "./parse.mjs"
 export {httpResponseSerializer, HttpBodySerializer, HttpBodySerializerMap} from "./serialize.mjs"
 export {normalizeEventHeaders, normalizeHeaders, getContentType} from "./utils.mjs"
 export {Router} from "./router.mjs"

diff --git a/packages/rest/src/runtime/parse.mts b/packages/rest/src/runtime/parse.mts
@@ -9,7 +9,7 @@ export type HttpBodyParser = (body: Buffer) => unknown
 
 export type HttpBodyParserMap = Partial<Record<MimeType | "default", HttpBodyParser>>
 
-export class NornirParseError extends NornirRestError {
+export class NornirRestParseError extends NornirRestError {
     constructor(cause: Error) {
         super("Failed to parse request. Bad content-type or invalid body", cause)
         this.cause = cause;
@@ -21,9 +21,7 @@ export class NornirParseError extends NornirRestError {
             headers: {
               "content-type": MimeType.TextPlain,
             },
-            body: {
-                message: this.message,
-            }
+            body: this.message
         }
     }
 }
@@ -51,7 +49,7 @@ export function httpEventParser(bodyParserMap?: HttpBodyParserMap, queryStringPa
                 query: queryStringParser(event.rawQuery),
             }
         } catch (error) {
-            throw new NornirParseError(error as Error)
+            throw new NornirRestParseError(error as Error)
         }
     }
 }