fix: fix issue with JSON ref resolver producing duplicate results #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When attempting to resolve JSON refs for an array of components of length > 1, and if none of the components have a
ref
property, it effectively overwrites theresult
object with the "current" result over every iteration in themap
which leads to the final result being an array of duplicates of whatever the last component is.This becomes an issue when validating an OpenAPI schema with
required = true
parameters because the resulting resolved spec will contain duplicaterequired = true
parameters of the same name, which is a schema violation.Solution
Pass an empty object to the
simpleSpecResolveInternal
call in the array mapping because we should be generating "new" results per map iteration, not using whatever the previous "result" is.Testing
New test added to
utils.spec.mts