Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/gradle args with spaces #831

Closed

Conversation

keeganjm-bsc
Copy link

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

@keeganjm-bsc
Copy link
Author

This PR is related to jfrog/jfrog-cli#921 and jfrog/jfrog-cli#2029 is needed to pass in multiple tags with space. For example:
-Dkarate.options="--tags=@smoke --tags=~@regression"

This command fails when being passed as the gradle command using jfrog cli like so
'jfrog rt gradle clean assemble myTest -Dkarate.options="--tags=@smoke --tags=~@regression"'

Currently the gradleCmd is not taking the complete value of -Dkarate.options and is interpreting the white space in the command as a break in the cmd line argument for -Dkarate.options and is then looking at --tags as a commandline argument. Here is an example of how it is appearing in the logs.

'jfrog rt gradle clean assemble myTest -Dkarate.options=--tags=@smoke --tags=~@regression'

Note the space after '@smoke'. This is what appears to be causing us issues. As the error coming into our logs is saying --tags is not a command line argument.

@keeganjm-bsc keeganjm-bsc marked this pull request as ready for review June 19, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant