Skip to content

Commit

Permalink
Add tests
Browse files Browse the repository at this point in the history
  • Loading branch information
orz25 committed Sep 9, 2024
1 parent 15299a2 commit 3ccd19c
Show file tree
Hide file tree
Showing 3 changed files with 34 additions and 2 deletions.
4 changes: 3 additions & 1 deletion formats/sarifutils/sarifutils.go
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,9 @@ func GetRulesPropertyCount(property, value string, runs ...*sarif.Run) (count in

func GetResultFingerprint(result *sarif.Result) string {
if result.Fingerprints != nil {
return result.Fingerprints[jasutils.SastFingerprintKey].(string)
if value, ok := result.Fingerprints[jasutils.SastFingerprintKey].(string); ok {
return value
}
}
return ""
}
28 changes: 28 additions & 0 deletions formats/sarifutils/sarifutils_test.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package sarifutils

import (
"github.com/jfrog/jfrog-cli-security/utils/jasutils"
"path/filepath"
"testing"

Expand Down Expand Up @@ -615,3 +616,30 @@ func TestGetInvocationWorkingDirectory(t *testing.T) {
assert.Equal(t, test.expectedOutput, GetInvocationWorkingDirectory(test.invocation))
}
}

func TestGetResultFingerprint(t *testing.T) {
tests := []struct {
name string
result *sarif.Result
expectedOutput string
}{
{
name: "No results",
result: &sarif.Result{},
expectedOutput: "",
},
{
name: "Empty fingerprint field in the result",
result: CreateResultWithLocations("msg", "rule", "level"),
expectedOutput: "",
},
{
name: "Results with fingerprint field",
result: CreateDummyResultWithFingerprint("some_markdown", "masg", jasutils.SastFingerprintKey, "sast_fingerprint"),
expectedOutput: "sast_fingerprint",
},
}
for _, test := range tests {
assert.Equal(t, test.expectedOutput, GetResultFingerprint(test.result))
}
}
4 changes: 3 additions & 1 deletion formats/sarifutils/test_sarifutils.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
package sarifutils

import "github.com/owenrumney/go-sarif/v2/sarif"
import (
"github.com/owenrumney/go-sarif/v2/sarif"
)

func CreateRunWithDummyResultsInWd(wd string, results ...*sarif.Result) *sarif.Run {
return createRunWithDummyResults("", results...).WithInvocations([]*sarif.Invocation{sarif.NewInvocation().WithWorkingDirectory(sarif.NewSimpleArtifactLocation(wd))})
Expand Down

0 comments on commit 3ccd19c

Please sign in to comment.