Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flaky test results in TestOperationalRiskSimplifiedViolation test… #139

Merged
merged 2 commits into from
Aug 11, 2024

Conversation

dortam888
Copy link
Contributor

@dortam888 dortam888 commented Aug 8, 2024

… by soting the violations resulting from simplifyViolations function

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

Fix Flaky behavior in the TestOperationalRiskSimplifiedViolation test that makes the test sometimes fail due to stability in the array when using the simplifyViolations function. If I have violations {violation1, violation2} after calling simplifyViolations(violations, true/false) the return value would be either {violation1, violation2} or {violation2, violation1}.
Sorting the array in order of the component key makes the result stable.

… by soting the violations resulting from simplifyViolations function
@dortam888 dortam888 added bug Something isn't working safe to test Approve running integration tests on a pull request labels Aug 9, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 9, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Aug 11, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 11, 2024
@attiasas attiasas added ignore for release Automatically generated release notes and removed bug Something isn't working labels Aug 11, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Aug 11, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 11, 2024
Copy link

👍 Frogbot scanned this pull request and did not find any new security issues.


@attiasas attiasas merged commit dc8e24b into jfrog:dev Aug 11, 2024
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore for release Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants