Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues from PR #136 #140

Merged
merged 2 commits into from
Aug 11, 2024
Merged

Fix issues from PR #136 #140

merged 2 commits into from
Aug 11, 2024

Conversation

igorz-jf
Copy link
Contributor

@igorz-jf igorz-jf commented Aug 11, 2024 •
edited
Loading

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

@attiasas attiasas added bug Something isn't working safe to test Approve running integration tests on a pull request labels Aug 11, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 11, 2024
@github-actions GitHub Actions
Copy link

👍 Frogbot scanned this pull request and did not find any new security issues.

attiasas
attiasas approved these changes Aug 11, 2024
View reviewed changes
Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@attiasas attiasas merged commit c7d7688 into jfrog:dev Aug 11, 2024
7 of 9 checks passed
@attiasas attiasas added ignore for release Automatically generated release notes and removed bug Something isn't working labels Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@attiasas attiasas attiasas approved these changes

Assignees
No one assigned
Labels
ignore for release Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igorz-jf @attiasas