Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build scan command table printing with --vuln=true #157

Closed
wants to merge 2 commits into from
Closed

Fix build scan command table printing with --vuln=true #157

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d39bea4
fixed logic for build scan command that made it print the vulnerabili…
dortam888 Aug 25, 2024
68a8089
Merge branch 'dev' into build-scan-vuln
dortam888 Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion commands/scan/buildscan.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,6 @@ func (bsc *BuildScanCommand) runBuildScanAndPrintResults(xrayManager *xray.XrayS

resultsPrinter := utils.NewResultsWriter(scanResults).
SetOutputFormat(bsc.outputFormat).
SetIncludeVulnerabilities(bsc.includeVulnerabilities).
SetIncludeLicenses(false).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after removing this line - did you test the CLI behaviour with and without watches?

Copy link
Contributor Author

@dortam888 dortam888 Aug 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hadarshjfrog I did the regular tests there is no watch test in jf build-scan (must have a watch with fail build policy).
This line doesn't affect watches as it relates to vulnerabilities. (and watches are affecting violations).
We call SetIncludeVulnerabilities in line 179 if vulnerabilities should be added.
https://github.com/jfrog/jfrog-cli-security/blob/main/commands/scan/buildscan.go#L180

SetIsMultipleRootProject(true).
SetPrintExtendedTable(bsc.printExtendedTable).
Expand Down
Loading