Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show only requested scanners in SARIF format #185

Merged
merged 5 commits into from
Sep 23, 2024
Merged

Show only requested scanners in SARIF format #185

merged 5 commits into from
Sep 23, 2024

Conversation

eyalk007
Copy link
Contributor

@eyalk007 eyalk007 commented Sep 22, 2024 •
edited
Loading

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

I added a check to the sarif output to append only information from requested scanners

@eyalk007 eyalk007 self-assigned this Sep 22, 2024
@eyalk007 eyalk007 added the bug Something isn't working label Sep 22, 2024
@eyalk007 eyalk007 changed the base branch from main to dev September 22, 2024 09:19
@eyalk007 eyalk007 added the safe to test Approve running integration tests on a pull request label Sep 22, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 22, 2024
@eyalk007 eyalk007 added the safe to test Approve running integration tests on a pull request label Sep 22, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 22, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Sep 23, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 23, 2024
attiasas
attiasas reviewed Sep 23, 2024
View reviewed changes
Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title is not very informative, I would change it to Show only requested scanners in SARIF format

utils/securityJobSummary.go Outdated Show resolved Hide resolved
utils/resultwriter.go Outdated Show resolved Hide resolved
@eyalk007 eyalk007 changed the title Fix append scanners to sarif Show only requested scanners in SARIF format Sep 23, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Sep 23, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 23, 2024
attiasas
attiasas reviewed Sep 23, 2024
View reviewed changes
Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, see my comment

utils/resultwriter.go Outdated Show resolved Hide resolved
utils/resultwriter.go Outdated Show resolved Hide resolved
@eyalk007 eyalk007 force-pushed the bug-fix/fix-append-scanners-to-sarif branch from ffb729d to e594fcc Compare September 23, 2024 10:09
@eyalk007 eyalk007 force-pushed the bug-fix/fix-append-scanners-to-sarif branch from e594fcc to b743f68 Compare September 23, 2024 10:11
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Sep 23, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 23, 2024
@eyalk007 eyalk007 added the safe to test Approve running integration tests on a pull request label Sep 23, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 23, 2024
@github-actions GitHub Actions
Copy link

👍 Frogbot scanned this pull request and did not find any new security issues.

@eyalk007 eyalk007 merged commit 8306f5b into jfrog:dev Sep 23, 2024
10 of 13 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Sep 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@attiasas attiasas attiasas approved these changes

Assignees

@eyalk007 eyalk007

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eyalk007 @attiasas