Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If project flag provided with empty value, act like there is no project #22

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Feb 15, 2024

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.

Flags always have priority over environment variables. However, if the JFROG_CLI_BUILD_PROJECT environment variable is set to --project='', it's considered as the project being provided.

@yahavi yahavi added the bug Something isn't working label Feb 15, 2024
@yahavi yahavi self-assigned this Feb 15, 2024
@yahavi yahavi requested a review from attiasas February 15, 2024 10:38
@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Feb 15, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 15, 2024
Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yahavi yahavi merged commit 6cef0a1 into dev Feb 15, 2024
12 of 15 checks passed
@yahavi yahavi deleted the fix-project-provided branch February 15, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants