Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit - Fix UseWrapper for Gradle/Maven dep tree #43

Merged
merged 3 commits into from
Mar 21, 2024
Merged

Audit - Fix UseWrapper for Gradle/Maven dep tree #43

merged 3 commits into from
Mar 21, 2024

Conversation

attiasas
Copy link
Contributor

@attiasas attiasas commented Mar 21, 2024 •
edited
Loading

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.
  • Passing the parameter 'UseWrapper' to the deptreemanager for Java that was missing.

@attiasas attiasas added bug Something isn't working safe to test Approve running integration tests on a pull request labels Mar 21, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 21, 2024
@github-actions GitHub Actions
Copy link

👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.

yahavi
yahavi approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@yahavi yahavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@attiasas attiasas merged commit c86ea9b into jfrog:dev Mar 21, 2024
4 of 5 checks passed
@attiasas attiasas deleted the fix_gradle_dep_tree_conc branch March 21, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahavi yahavi yahavi approved these changes

@eranturgeman eranturgeman Awaiting requested review from eranturgeman

@hadarshjfrog hadarshjfrog Awaiting requested review from hadarshjfrog

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@attiasas @yahavi