Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use multi-scan-id as env variable #5

Merged
merged 4 commits into from
Jan 22, 2024
Merged

Use multi-scan-id as env variable #5

merged 4 commits into from
Jan 22, 2024

Conversation

orz25
Copy link
Contributor

@orz25 orz25 commented Jan 18, 2024

Analyzer Manager is expecting to get the multi_scan_id as env variable named JF_MSI.

PR for creating this env variable right after we get the multi_scan_id from xsc (in jfrog-client-go):
jfrog/jfrog-client-go#883

@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Jan 18, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 18, 2024
@attiasas attiasas added bug Something isn't working safe to test Approve running integration tests on a pull request labels Jan 22, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 22, 2024
Copy link

👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.


@@ -91,12 +91,13 @@ func (am *AnalyzerManager) ExecWithOutputFile(configFile, scanCommand, workingDi
return
}
var cmd *exec.Cmd
multiScanId := os.Getenv("JF_MSI")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure "JF_MSI" is defined as const.

@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Jan 22, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 22, 2024
@attiasas attiasas changed the title getting multi scan id as env variable Use multi-scan-id as env variable Jan 22, 2024
@attiasas attiasas merged commit edf9cb4 into jfrog:dev Jan 22, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants