Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancements for XSC analytics metrics capabilities to support application in Frogbot #50

Merged
merged 35 commits into from
Apr 10, 2024
Merged

Enhancements for XSC analytics metrics capabilities to support application in Frogbot #50

merged 35 commits into from
Apr 10, 2024

Conversation

eranturgeman
Copy link
Contributor

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

gailazar300 and others added 27 commits March 24, 2024 17:07
@gailazar300
Add Xsc General Event
12dbe00
@gailazar300
Add Xsc General Event
cbc4fcd
@gailazar300
Before review fixes.
1951727
@gailazar300
Add UpdateGeneralEvent.
c834ad1
@gailazar300
Set environments variables for analyzer manager.
f9c9c0e
@gailazar300
Add tests.
a4f0534
@gailazar300
Remove error handling for analytics.
abc6553
@gailazar300
Change AnalyticsMetricsService creation.
e79cb1e
@gailazar300
Merge remote-tracking branch 'upstream/dev' into feature/XRAY-36905
b45d003 
# Conflicts:
#	go.sum
@gailazar300
go.mod+sum
b3452da
@gailazar300
Minor fixes.
fdb5051
@gailazar300
Review fixes.
4c68943
@gailazar300
Add integration test.
2c9fcba
@gailazar300
Minor fixes.
fc0f2df
@gailazar300
Change add general event flow for Frogbot.
b9560da
@gailazar300
Second review fixes.
040ce9b
@gailazar300
Remove Frogbot's MSI validation - there is no common flow for cli and…
40884cb 
… Frogbot for analytics.
@gailazar300
Minor fix.
51de09a
@gailazar300
Minor fix.
df4ef8f
@gailazar300
Minor fix.
08b1764
@gailazar300
Change UpdateGeneralEvent & moving relevant code from core
afc8843
@gailazar300
go.mod+sum
b133a9a
@gailazar300
minor fix
1a2c652
@gailazar300
minor fix
abea15c
@gailazar300
Fix sending scan to xsc if available.
f0fdb3a
@gailazar300
Add CountScanResultsFindings.
e30c3d2
@eranturgeman
adding function and methods to support analytics report in Frogbot
15164f4
@eranturgeman eranturgeman marked this pull request as draft April 3, 2024 15:02
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Apr 8, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 8, 2024
@eranturgeman eranturgeman changed the title Analytics events additions Enhancements for XSC analytics metrics capabilities to support application in Frogbot Apr 8, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Apr 8, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 8, 2024
@eranturgeman
Merge branch 'dev' of https://github.com/jfrog/jfrog-cli-security int…
3c402ab 
…o additions-for-analytics

# Conflicts:
#	commands/audit/audit.go
#	commands/audit/jas/common.go
#	commands/audit/jas/common_test.go
#	go.mod
#	go.sum
#	tests/utils/test_validation.go
#	utils/analyticsmetrics.go
#	utils/analyticsmetrics_test.go
@eranturgeman
resolve conflicts
bd25380
@eranturgeman
resolve conflicts
f2ccfe7
@eranturgeman
resolve conflicts
7a48891
@eranturgeman
fix tests issues
fdc7dd5
attiasas
attiasas reviewed Apr 9, 2024
View reviewed changes
Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

utils/analyticsmetrics.go Show resolved Hide resolved
utils/results.go Outdated Show resolved Hide resolved
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Apr 9, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 9, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Apr 10, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 10, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Apr 10, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 10, 2024
@github-actions GitHub Actions
Copy link

👍 Frogbot scanned this pull request and did not find any new security issues.

@eranturgeman eranturgeman merged commit f7cd2c5 into jfrog:dev Apr 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@attiasas attiasas attiasas approved these changes

@gailazar300 gailazar300 Awaiting requested review from gailazar300

Assignees
No one assigned
Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eranturgeman @attiasas @gailazar300