Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker - Fix tests #2096

Merged
merged 5 commits into from
Jul 25, 2023
Merged

Docker - Fix tests #2096

merged 5 commits into from
Jul 25, 2023

Conversation

Or-Geva
Copy link
Contributor

@Or-Geva Or-Geva commented Jul 23, 2023 •
edited
Loading

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

We have encountered an issue with some Docker tests that use the library testcontainers.
We are temporarily downgrading to Go 1.20.5 due to a bug in version 1.20.6 that causes testcontainers to fail.

@Or-Geva Or-Geva changed the title Fix docker test2 Tests - Delay docker in docker tests Jul 23, 2023
@Or-Geva Or-Geva added the safe to test Approve running integration tests on a pull request label Jul 23, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 23, 2023
@Or-Geva Or-Geva added safe to test Approve running integration tests on a pull request ignore for release Automatically generated release notes labels Jul 25, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 25, 2023
@Or-Geva Or-Geva added the safe to test Approve running integration tests on a pull request label Jul 25, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 25, 2023
@Or-Geva Or-Geva changed the title Tests - Delay docker in docker tests Docker - Fix tests Jul 25, 2023
@Or-Geva Or-Geva temporarily deployed to frogbot July 25, 2023 14:39 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

@Or-Geva Or-Geva merged commit 744a7f1 into jfrog:dev Jul 25, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sverdlov93 sverdlov93 sverdlov93 approved these changes

@yahavi yahavi Awaiting requested review from yahavi

@eyalbe4 eyalbe4 Awaiting requested review from eyalbe4

Assignees
No one assigned
Labels
ignore for release Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Or-Geva @sverdlov93