Exclude keytar from Webpacking (#118)

jfrog · Aug 15, 2021 · 1d320ac · 1d320ac
1 parent 6ec42c9
commit 1d320ac
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 47 deletions.
diff --git a/.vscodeignore b/.vscodeignore
@@ -3,6 +3,7 @@
 out/test/**
 src/**
 node_modules/**
+!node_modules/keytar
 .gitignore
 **/tsconfig.json
 **/tslint.json

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -261,7 +261,6 @@
         "faker": "^5.5.3",
         "glob": "^7.1.7",
         "mocha": "^9.0.3",
-        "node-loader": "^2.0.0",
         "prettier": "^1.19.1",
         "tmp": "^0.2.1",
         "ts-loader": "^9.2.5",

diff --git a/webpack.config.js b/webpack.config.js
@@ -16,7 +16,8 @@ const config = {
     },
     devtool: 'source-map',
     externals: {
-        vscode: 'commonjs vscode'
+        vscode: 'commonjs vscode',
+        keytar: 'keytar'
     },
     resolve: {
         extensions: ['.ts', '.js']
@@ -28,10 +29,6 @@ const config = {
                 test: /\.ts$/,
                 exclude: /node_modules/,
                 loader: 'ts-loader'
-            },
-            {
-                test: /\.node$/,
-                loader: 'node-loader'
             }
         ]
     },