Skip to content

Commit

Permalink
Remove trailing slash from GitHub OIDC provider URL
Browse files Browse the repository at this point in the history
  • Loading branch information
alexhung committed May 6, 2024
1 parent d8825ac commit 6de92ba
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion pkg/platform/resource_oidc_configuration.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import (

const (
gitHubProviderType = "GitHub"
gitHubProviderURL = "https://token.actions.githubusercontent.com/"
gitHubProviderURL = "https://token.actions.githubusercontent.com"
odicConfigurationEndpoint = "/access/api/v1/oidc"
)

Expand Down
2 changes: 1 addition & 1 deletion pkg/platform/resource_oidc_configuration_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ func TestAccOIDCConfiguration_invalid_provider_type_issuer_url(t *testing.T) {
Steps: []resource.TestStep{
{
Config: config,
ExpectError: regexp.MustCompile(`must be set to https:\/\/token\.actions\.githubusercontent\.com\/`),
ExpectError: regexp.MustCompile(`must be set to https:\/\/token\.actions\.githubusercontent\.com[^\/]`),
},
},
})
Expand Down

0 comments on commit 6de92ba

Please sign in to comment.