Add OIDC role mapping #137
Conversation
There was a problem hiding this comment.
Please also add test for the roles scope. See https://github.com/jfrog/terraform-provider-platform/blob/main/pkg/platform/resource_oidc_identity_mapping_test.go#L130 for example.
| @@ -97,11 +97,11 @@ func (r *odicIdentityMappingResource) Schema(ctx context.Context, req resource.S | |||
| Required: true, | |||
| Validators: []validator.String{ | |||
| stringvalidator.RegexMatches( | |||
| regexp.MustCompile(`^(applied-permissions\/admin|applied-permissions\/user|applied-permissions\/groups:.+)$`), | |||
| "must start with either 'applied-permissions/admin', 'applied-permissions/user', or 'applied-permissions/groups:'", | |||
| regexp.MustCompile(`^(applied-permissions\/admin|applied-permissions\/user|applied-permissions\/groups|applied-permissions\/roles:.+)$`), | |||
There was a problem hiding this comment.
The trailing : is missing for the groups.
There was a problem hiding this comment.
The : is still missing. Should be applied-permissions\/groups:
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Done |
@akhter-ali-idexx Excellent! Can you also try to sign the CLA? The bot may fails but that's ok as long as you sign. |
akhter-ali-idexx
had a problem deploying
to
development
GitHub Actions
Failure
akhter-ali-idexx
had a problem deploying
to
development
GitHub Actions
Error
|
I have read the CLA Document and I hereby sign the CLA |
|
Wow, I completely missed that, lol. Test execution added |
|
@alexhung Please do let me know if I've missed anything else, I'd like to use asap. Thank you! |
akhter-ali-idexx
had a problem deploying
to
development
GitHub Actions
Error
akhter-ali-idexx
had a problem deploying
to
development
GitHub Actions
Failure
akhter-ali-idexx
had a problem deploying
to
development
GitHub Actions
Failure
akhter-ali-idexx
had a problem deploying
to
development
GitHub Actions
Failure
| @@ -97,11 +97,11 @@ func (r *odicIdentityMappingResource) Schema(ctx context.Context, req resource.S | |||
| Required: true, | |||
| Validators: []validator.String{ | |||
| stringvalidator.RegexMatches( | |||
| regexp.MustCompile(`^(applied-permissions\/admin|applied-permissions\/user|applied-permissions\/groups:.+)$`), | |||
| "must start with either 'applied-permissions/admin', 'applied-permissions/user', or 'applied-permissions/groups:'", | |||
| regexp.MustCompile(`^(applied-permissions\/admin|applied-permissions\/user|applied-permissions\/groups|applied-permissions\/roles:.+)$`), | |||
There was a problem hiding this comment.
The : is still missing. Should be applied-permissions\/groups:
No description provided.