Add repo config 'exposures' to support JAS #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmkn
requested changes
Aug 17, 2023
docs/resources/repository_config.md
Outdated
| Optional: | ||
|
|
||
| - `applications` (Boolean) Detect whether common OSS libraries and services are used securely by the application. | ||
| - `iac` (Boolean) Scans IaC files stored in Artifactory for early detection of cloud and infrastructure misconfigurations to prevent attacks and data leak. Only support by Terraform Backend package type. |
| } | ||
|
|
||
| type ScannersCategory struct { | ||
| MaliciousCode bool `json:"malicious_code_scan,omitempty"` |
There was a problem hiding this comment.
It's better not to use omitempty with bools.
There was a problem hiding this comment.
Can't as the API errors out if the not-applicable fields are present. The API will only accept the valid fields for the repo type. The 'better' way will be to use map[string]bool struct and dynamically add only the valid fields (vs using omitempty). This will mean we need to fetch the repo details from RT first to determine its type, then set the fields according to that.
| Optional: true, | ||
| Description: "Scans IaC files stored in Artifactory for early detection of cloud and infrastructure misconfigurations to prevent attacks and data leak. Only support by Terraform Backend package type.", | ||
| }, | ||
| "applications": { |
There was a problem hiding this comment.
Should we have defaults for all booleans here? And remove omitempty in the struct?
And fills in the fields based on package type (and Xray version) Apply the same logic to vulnerability contextual analysis.
danielmkn
previously approved these changes
Aug 21, 2023
MahithaB
previously approved these changes
Aug 21, 2023
danielmkn
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.