Skip to content

Commit

Permalink
github/ci: fixing merge conflict with coverage uploading
Browse files Browse the repository at this point in the history
  • Loading branch information
jgaeddert committed Apr 29, 2024
1 parent 6033de0 commit 7389c00
Showing 1 changed file with 12 additions and 13 deletions.
25 changes: 12 additions & 13 deletions .github/workflows/coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,17 +46,16 @@ jobs:
- name: make coverage
run: make -j 2 coverage

- name: upload report to codecov with github action
uses: codecov/codecov-action@v4
with:
fail_ci_if_error: true
verbose: true
token: ${{ secrets.CODECOV_TOKEN }}
# prefer codecov action (below), but produces 'unusable report';
- name: upload report to codecov using bash script
run: bash <(curl -s https://codecov.io/bash)
# prefer codecov action, but produces 'unusable report';
# (suspect path fixing needed: https://docs.codecov.com/docs/fixing-paths)
#uses: codecov/codecov-action@v3
#with:
# fail_ci_if_error: true
# verbose: true
# files: coverage.out

# NOTE: this fails to upload
# (suspect path fixing needed: https://docs.codecov.com/docs/fixing-paths)
#- name: upload report to codecov with github action
# uses: codecov/codecov-action@v4
# with:
# fail_ci_if_error: true
# verbose: true
# token: ${{ secrets.CODECOV_TOKEN }}

0 comments on commit 7389c00

Please sign in to comment.