Merge #87
Merged
Merge #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update deps for minimap2-sys
@rob-p Dunno if you can test it, or added the proper tests? @mbhall88 Query name is passed in as AsRef<[u8]> and there is some not my favorite code in there to prevent a new allocation if the query name is already nul-allocated, and to do an allocation if needed. Also I've updated Mappings to return Arc<String>'s for query name and target name, which should decrease performance for very small jobs but increase for large jobs.... but I need to benchmark
…dd better docs stating presets should be called before any other options, to follow minimap2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.