Merge pull request #2494 from jhaals/fix-empty-secret

website(fix): reject empty secrets
jhaals · Oct 9, 2024 · 7dd6c64 · 7dd6c64
2 parents 8bfe07b + 0bc38d1
commit 7dd6c64
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 4 deletions.
diff --git a/website/src/createSecret/CreateSecret.tsx b/website/src/createSecret/CreateSecret.tsx
@@ -51,6 +51,9 @@ const CreateSecret = () => {
   };
 
   const onSubmit = async (form: any): Promise<void> => {
+    if (!form.secret) {
+      return;
+    }
     // Use the manually entered password, or generate one
     const pw = form.password ? form.password : randomString();
     setLoading(true);
@@ -117,8 +120,10 @@ const CreateSecret = () => {
                 rows="4"
                 autoFocus={true}
                 onKeyDown={onKeyDown}
-                placeholder={t<string>('create.inputSecretPlaceholder')}
-                inputProps={{ spellCheck: 'false', 'data-gramm': 'false' }}
+                placeholder={t('create.inputSecretPlaceholder')}
+                slotProps={{
+                  htmlInput: { spellCheck: 'false', 'data-gramm': 'false' },
+                }}
               />
             )}
           />
@@ -199,6 +204,13 @@ export const SpecifyPasswordInput = (props: { control: Control<any> }) => {
               spellCheck: 'false',
               'data-gramm': 'false',
             }}
+            slotProps={{
+              htmlInput: {
+                spellCheck: 'false',
+                'data-gramm': 'false',
+                autoComplete: 'false',
+              },
+            }}
           />
         )}
       />

diff --git a/website/src/createSecret/Upload.tsx b/website/src/createSecret/Upload.tsx
@@ -101,7 +101,7 @@ const Upload = () => {
   }
   return (
     <Grid>
-      {isFileTooLarge && <Error message={t<string>('upload.fileTooLarge')} />}
+      {isFileTooLarge && <Error message={t('upload.fileTooLarge')} />}
       <Error message={error} onClick={() => setError('')} />
       <form onSubmit={handleSubmit(onSubmit)}>
         <div {...getRootProps()}>

diff --git a/website/src/displaySecret/DisplaySecret.tsx b/website/src/displaySecret/DisplaySecret.tsx
@@ -54,7 +54,7 @@ const EnterDecryptionKey = ({
             autoFocus
             name="decryptionKey"
             id="decryptionKey"
-            placeholder={t<string>('display.inputDecryptionKeyPlaceholder')}
+            placeholder={t('display.inputDecryptionKeyPlaceholder')}
             label={t('display.inputDecryptionKeyLabel')}
             value={tempPassword}
             error={invalidPassword}