Skip to content

Commit

Permalink
Fix app notariztion
Browse files Browse the repository at this point in the history
  • Loading branch information
jhen0409 committed Jul 18, 2023
1 parent a7e47e0 commit b7b1efb
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 11 deletions.
12 changes: 6 additions & 6 deletions scripts/mac/createUniversalApp.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@ async function run() {
await signAsync({
app: p,
identity: `Developer ID Application: ${developerId}`,
optionsForFile: (filePath) => ({
optionsForFile: () => ({
hardenedRuntime: true,
entitlements: `${filePath}scripts/mac/entitlements.plist`,
entitlements: 'scripts/mac/entitlements.plist',
}),
platform: 'darwin',
version: electronVersion,
Expand All @@ -47,10 +47,10 @@ async function run() {
console.log(e);
}
await notarize({
appleId: process.env.APPLE_ID,
appleIdPassword: '@keychain:AC_PASSWORD',
teamId: process.env.APPLE_TEAM_ID,
appBundleId: 'com.electron.react-native-debugger',
tool: 'notarytool',
// xcrun notarytool store-credentials "AC_PASSWORD"
// --apple-id "xxx" --team-id "xxx" --password "<app-specific-password>"
keychainProfile: 'AC_PASSWORD',
appPath: p,
});
}
Expand Down
5 changes: 0 additions & 5 deletions scripts/package-macos.sh
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,6 @@ if [ "$1" == "--no-notarize" ]; then
fi

if [ "$NOTARIZE" != "0" ]; then
if [ -z "$APPLE_ID" ]; then
echo -e "Apple ID: \c"
read APPLE_ID
fi

if [ -z "$APPLE_DEVELOPER_NAME" ]; then
echo -e "Apple Developer Name: \c"
read APPLE_DEVELOPER_NAME
Expand Down

0 comments on commit b7b1efb

Please sign in to comment.