feat: improve binary expression formatting

[jtkiesel]

What changed with this PR:

Binary expressions are now broken, indented, and wrapped with parentheses similar to the way Prettier JavaScript does. I tried to mimic the behavior of Prettier JavaScript as much as possible, except that this PR never removes parentheses around binary expressions, only adds them.

Example

Input

class Example {

  void example() {
    2 / 3 * 10 / 2 + 2;
    2 * 3 * 10 / 2 + 2;
    a % 10 - 5;
    a - 10 % 5;
    a * b % 10;
    a % b * 10;
    a % 10 > 5;
    1 << 2 >>> 3 >> 4;
    1 << 2 + 3;
    1 / 2 << 3;
    x == y == z;
    1 & 2 == 3;

    if (aaaaaaaaaa + bbbbbbbbbb == cccccccccc + dddddddddd && eeeeeeeeee + ffffffffff == gggggggggg + hhhhhhhhhh || iiiiiiiiii) {}

    if (a * b + c << d < e == f & g ^ h | i && j || k && l | m ^ n & o != p > q >> r - s / t) {}

    if (aaaaaaaaaa + bbbbbbbbbb == cccccccccc + dddddddddd && eeeeeeeeee + ffffffffff == gggggggggg + hhhhhhhhhh || iiiiiiiiii + jjjjjjjjjj == kkkkkkkkkk + llllllllll && mmmmmmmmmm + nnnnnnnnnn == oooooooooo + pppppppppp || qqqqqqqqqq + rrrrrrrrrr == ssssssssss + tttttttttt && uuuuuuuuuu + vvvvvvvvvv == wwwwwwwwww + xxxxxxxxxxx) {}
  }
}

Output

class Example {

  void example() {
    ((2 / 3) * 10) / 2 + 2;
    (2 * 3 * 10) / 2 + 2;
    (a % 10) - 5;
    a - (10 % 5);
    (a * b) % 10;
    (a % b) * 10;
    a % 10 > 5;
    ((1 << 2) >>> 3) >> 4;
    1 << (2 + 3);
    (1 / 2) << 3;
    (x == y) == z;
    1 & (2 == 3);

    if (
      (aaaaaaaaaa + bbbbbbbbbb == cccccccccc + dddddddddd &&
        eeeeeeeeee + ffffffffff == gggggggggg + hhhhhhhhhh) ||
      iiiiiiiiii
    ) {}

    if (
      (((((a * b + c) << d < e == f) & g) ^ h) | i && j) ||
      (k && l | (m ^ (n & (o != p > q >> (r - s / t)))))
    ) {}

    if (
      (aaaaaaaaaa + bbbbbbbbbb == cccccccccc + dddddddddd &&
        eeeeeeeeee + ffffffffff == gggggggggg + hhhhhhhhhh) ||
      (iiiiiiiiii + jjjjjjjjjj == kkkkkkkkkk + llllllllll &&
        mmmmmmmmmm + nnnnnnnnnn == oooooooooo + pppppppppp) ||
      (qqqqqqqqqq + rrrrrrrrrr == ssssssssss + tttttttttt &&
        uuuuuuuuuu + vvvvvvvvvv == wwwwwwwwww + xxxxxxxxxxx)
    ) {}
  }
}

Relative issues or prs:

None

[clementdessoude]

Wow ! Impressive job @jtkiesel ! I had a first look today, and it seems really good, but as this part is complex, I would like to have another look tomorrow if possible :)

Thanks a lot !

@pascalgrimaud @jdubois, @jtkiesel is doing a great job on Prettier Java this last few weeks, maybe it would be possible to assign a bounty on one or several of the PRs, WDYT ?

[jtkiesel]

@DanielFran Bounty claimed: https://opencollective.com/generator-jhipster/expenses/156004

[DanielFran]

@jtkiesel approved