Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rosbuild support in GenerateRTTRosCommPackage and rtt_ros service #11

Merged
merged 1 commit into from
Aug 30, 2013

Conversation

meyerj
Copy link

@meyerj meyerj commented Aug 30, 2013

This is a follow-up of #9. Not all goals mentioned there have been achieved yet, especially these two points:

rosbuild packages can find_package(rtt_roscomm) and call ros_generate_rtt_typekit() and ros_generate_rtt_service_proxies() on rosbuild message packages. This replaces the former rosbuild_include(rtt_rosnode GenerateRTTtypekit) call.

The rtt_ros service should be able to import rosbuild packages.

@jbohren
Copy link
Member

jbohren commented Aug 30, 2013

Looks good!

jbohren added a commit that referenced this pull request Aug 30, 2013
Add rosbuild support in GenerateRTTRosCommPackage and rtt_ros service
@jbohren jbohren merged commit f57d66d into hydro-devel Aug 30, 2013
@meyerj
Copy link
Author

meyerj commented Aug 30, 2013

There is still some more work to do here, especially the rosbuild support in the rtt_ros service. I just wanted to collect all patches here. I could look into it next week.

@jbohren
Copy link
Member

jbohren commented Aug 30, 2013

Yeah, though I haven't tested it yet, I think since the rtt_ros service uses the rospack C++ API, as long as the manifest.xml files have similar <export><rtt_ros><plugin_depend> tags, it will work exactly the same way. I'm going to respond to all of the other comments from Ruben and Peter over the next couple of hours.

@jbohren
Copy link
Member

jbohren commented Aug 30, 2013

We should probably re-vist the naming/design of those export tags too, since that's still open: #3

jbohren pushed a commit that referenced this pull request Jan 7, 2014
Move ROS-dependent packages from rtt_geometry to rtt_ros_integration (cleanup of #11)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants