Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete docker workflows #767

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Delete docker workflows #767

merged 1 commit into from
Jul 29, 2024

Conversation

avahoffman
Copy link
Contributor

@avahoffman avahoffman commented Jul 26, 2024

It's my understanding that these are no longer needed since the docker image originates in https://github.com/jhudsl/ottr-docker.

It also is a super-precaution for echoing git_token.txt anywhere near docker images. Deleting these will assuage some concerns about security.

Copy link
Contributor

github-actions bot commented Jul 26, 2024

No broken url errors! 🎉
Comment updated at 2024-07-26-18:46:15 with changes from a31d872

Copy link
Contributor

github-actions bot commented Jul 26, 2024

No spelling errors! 🎉
Comment updated at 2024-07-26-18:46:15 with changes from a31d872

Copy link
Contributor

Re-rendered previews from the latest commit:

* note not all html features will be properly displayed in the "quick preview" but it will give you a rough idea.

Updated at 2024-07-26 with changes from the latest commit a31d872

@cansavvy
Copy link
Collaborator

Yes you are correct they aren't needed I think if I remember correctly we brought them back in case someone who was using the template was making their own docker images but I think it just adds more confusion to add these here and deleting is the right move.

If someone is making their own docker file then copying over files won't be a roadblock for them anyway.

@cansavvy cansavvy merged commit de1b118 into main Jul 29, 2024
9 checks passed
@cansavvy cansavvy deleted the docker-fixes branch July 29, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants