Multiple fixes and improvements in mqtt client source #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
如果任务优先级比初始化的任务优先级高会导致无法连接, 因为新建的任务在进入的时候会检查这一个状态, 如果被抢占, 这一个状态就不会被修改
|
We cannot do that because this flag is not meant to be used in such way, MQTT_LOG_LEVEL is only for mqtt_log. It is better to do in such way to remove warning and not to not mix definitions: |
|
yes that's another way to do it. independent of LOG setting. I will modify that and push again. |
Signed-off-by: Ajay Bhargav <[email protected]>
This patch fix the issue where platform_thread_destroy do not actually delete the thread created, only memory free was done. Signed-off-by: Ajay Bhargav <[email protected]>
Compiler generate unused variable 'i' warning in mqtt_list_subscribe_topic when MQTT_LOG_LEVEL < MQTT_LOG_INFO_LEVEL. Signed-off-by: Ajay Bhargav <[email protected]>
SL-RU
approved these changes
Feb 23, 2024
| @@ -1463,6 +1463,8 @@ int mqtt_publish(mqtt_client_t* c, const char* topic_filter, mqtt_message_t* msg | |||
| int mqtt_list_subscribe_topic(mqtt_client_t* c) | |||
| { | |||
| int i = 0; | |||
|
|
|||
| (void) i; /* prevent compiler warning */ | |||
In tencentos implementation of platform_thread_destroy, stack size is getting freed where as stack base is suppose to be freed. platform_thread_t structure varaible is also not freed. this patch fix both the issues Signed-off-by: Ajay Bhargav <[email protected]>
Signed-off-by: Ajay Bhargav <[email protected]>
Task handle must be storead in temporary variable and then memory is to be freed. Else task exits before memory free is executed. Signed-off-by: Ajay Bhargav <[email protected]>
Signed-off-by: Ajay Bhargav <[email protected]>
Signed-off-by: Ajay Bhargav <[email protected]>
Signed-off-by: Ajay Bhargav <[email protected]>
when topic filter string passed to mqtt_subscribe via a local variable, topic subscribe is success but does not receive anything afterwards. This patch remove dependency of type of variable passed to mqtt_subscribe Signed-off-by: Ajay Bhargav <[email protected]>
last will topic and message is now allocated to remove dependency on variable type passed to function. Signed-off-by: Ajay Bhargav <[email protected]>
remove full path name from error and debug messages. Signed-off-by: Ajay Bhargav <[email protected]>
ajaybhargav
changed the title
This was referenced Feb 26, 2025
Signed-off-by: Ajay Bhargav <[email protected]>
Signed-off-by: Ajay Bhargav <[email protected]>
Signed-off-by: Ajay Bhargav <[email protected]>
Update mqttclient.c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiler generate unused variable 'i' warning in mqtt_list_subscribe_topic when MQTT_LOG_LEVEL < MQTT_LOG_INFO_LEVEL.