Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate parameter from "/schedules" path #518

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

BarraFiqaulihi
Copy link
Contributor

@BarraFiqaulihi BarraFiqaulihi commented Feb 24, 2024

Found it when I was importing the API to Postman.

Screenshot (133)

@BarraFiqaulihi BarraFiqaulihi requested a review from a team as a code owner February 24, 2024 18:05
@pushrbx
Copy link
Collaborator

pushrbx commented Feb 24, 2024

Thanks for contributing. Could you please also check if this thing is also duplicated anywhere in the code comments? We generate these json files based on the comments/annotations we add in the code.

@BarraFiqaulihi
Copy link
Contributor Author

Sure, will look into it.

@BarraFiqaulihi
Copy link
Contributor Author

Done 👌.

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.43%. Comparing base (bb88011) to head (e4263d1).

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #518   +/-   ##
=========================================
  Coverage     57.43%   57.43%           
  Complexity     1352     1352           
=========================================
  Files           339      339           
  Lines          5206     5206           
=========================================
  Hits           2990     2990           
  Misses         2216     2216           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@pushrbx pushrbx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@irfan-dahir irfan-dahir merged commit 1db1d3c into jikan-me:master Mar 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants