Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/microcaching including omitted attributes #560

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

irfan-dahir
Copy link
Contributor

@irfan-dahir irfan-dahir requested a review from a team as a code owner November 13, 2024 16:51
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 57.23%. Comparing base (2fa3958) to head (b8a24dc).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
app/Http/Middleware/MicroCaching.php 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #560      +/-   ##
============================================
- Coverage     57.24%   57.23%   -0.02%     
  Complexity     1391     1391              
============================================
  Files           340      340              
  Lines          5669     5670       +1     
============================================
  Hits           3245     3245              
- Misses         2424     2425       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@irfan-dahir irfan-dahir merged commit f9d6f87 into master Nov 13, 2024
3 checks passed
@irfan-dahir irfan-dahir deleted the bugfix/microcaching-including-omitted-attributes branch November 13, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Micro caching middleware includes omitted pagination attributes
2 participants