Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iOS targets #147

Merged
merged 4 commits into from
Jul 11, 2024
Merged

Conversation

lhoracek
Copy link

@lhoracek lhoracek commented Jul 2, 2024

I want to add iOS support to this project so we can leverage the DSL in our KMP project, but struggling with way to test it at the moment.

Feature request: #145

@lhoracek lhoracek mentioned this pull request Jul 2, 2024
@lhoracek lhoracek marked this pull request as ready for review July 2, 2024 17:21
@jillesvangurp
Copy link
Owner

Thanks for this. Let me know how this stuff works on IOS; you're technically the first to try this on IOS probably.

@jillesvangurp
Copy link
Owner

It's not currently building. I don't have the IOS sdks installed on my laptop so I can't really test this.

@lhoracek
Copy link
Author

This should fix it. I unintentionally broke Ktor dependencies for native target by adding this. I needed to split each native target and add dependencies explicitly. Changed dependency for macos to Darwin as well as it should be better fit.
There might be better solution but this builds ok now.
Will post some example outputs from iOS later today.

@lhoracek
Copy link
Author

I saw json-dsls PR for simulator was merge, once kotlinx-serialization-extensions is updated as well and release, we can enable the ios simulators target here as well.

@lhoracek
Copy link
Author

So I tested today, using only the search-dsls library to compose the query. Same output on iOS and Android.

@jillesvangurp jillesvangurp merged commit 8165076 into jillesvangurp:master Jul 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants