-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reset themes #58
Open
joslinpr
wants to merge
65
commits into
jimeh:master
Choose a base branch
from
joslinpr:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add reset themes #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reorder Includes so overrides work Paul: Use only 2 left and right status slots
Use local apply and affix files Make after changes
Make _apply and _themepack-options part of Paul theme Make Paul/block actually blocky. Rebuild all themes
…ath to allow alternate themes
…nto SIMPLEPAUL
… into SIMPLEPAUL
…nto SIMPLEPAUL
Simplepaul
All: Remove -gq, use -g All: Use -gwF where needed block-simple: Fix separator
Add settitle, to change session, window, pane titles Update pane-border-format Override pane-border-format for block-simple Add SetEnv to setup dev environment
Tools: Use $HOME instead of hard coded directory PANE - In 2.7, turn pane-status on, set-window-options instead of set-option
Makefile cleanup Minify remove most comments
Significant Refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The themes use
set -goq
. From the man page:As a result, once a theme is set, you cannot change it. This PR creates two themes for developers. The "reset.tmuxtheme" uses
set -gq
, so that it overrides existing variables.The "reset-debug.tmuxtheme" uses
set -g
, so that variables are overridden, and error messages are not suppressed.Steps to demonstrate the problem:
Load a theme, then load a second theme. The values of the first theme remain.
An alternate enhancement would be to use
set -gq
in all themes. I do not know whygoq
was chosen, so I have not changed those themes.