Reply when no images are found.

jimmycuadra · Aug 20, 2013 · 0ec4afb · 0ec4afb
1 parent 86d7e4f
commit 0ec4afb
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/lib/lita/handlers/google_images.rb b/lib/lita/handlers/google_images.rb
@@ -28,7 +28,11 @@ def fetch(response)
 
         if data["responseStatus"] == 200
           choice = data["responseData"]["results"].sample
-          response.reply "#{choice["unescapedUrl"]}#.png"
+          if choice
+            response.reply "#{choice["unescapedUrl"]}#.png"
+          else
+            response.reply %{No images found for "#{query}".}
+          end
         else
           reason = data["responseDetails"] || "unknown error"
           Lita.logger.warn(

diff --git a/spec/lita/handlers/google_images_spec.rb b/spec/lita/handlers/google_images_spec.rb
@@ -35,6 +35,15 @@
       )
     end
 
+    it "replies that no images were found if the results are empty" do
+      allow(response).to receive(:body).and_return(<<-JSON.chomp
+{"responseStatus": 200, "responseData": { "results": [] } }
+JSON
+      )
+      send_command("image carl")
+      expect(replies.last).to eq(%{No images found for "carl".})
+    end
+
     it "logs a warning on failure" do
       allow(response).to receive(:body).and_return(<<-JSON.chomp
 {