Feat: Add test for logs in LogView

jina-ai · Feb 8, 2021 · 7c0492c · 7c0492c
1 parent 3fcc0c5
commit 7c0492c
Show file tree

Hide file tree

Showing 6 changed files with 20 additions and 5 deletions.
diff --git a/dev-resources/sample-data/sample-output.json → cypress/fixtures/sample-output.json b/dev-resources/sample-data/sample-output.json → cypress/fixtures/sample-output.json
diff --git a/cypress/integration/views/logsView.ts b/cypress/integration/views/logsView.ts
@@ -25,6 +25,20 @@ describe('Logs page', () => {
         cy.dataName('logOccurenceDurationSelectedOption').should('contain.text', '15 Minutes')
       })
     })
-  })
 
+    context('when starting a flow',  () => {
+      it('should display the correct logging', () => {
+        cy.visit('#/flow')
+        cy.dataName('playButton').click()
+        cy.visit('#/logs')
+        cy.wait(5000)
+        cy.fixture('sample-output').then((output)=>{
+          console.log(output.logs[0])
+          output.logs.forEach((log, index) => {
+            cy.dataName(`logItem-${index}`).should('contain', log.message)
+          })
+        })
+      })
+    })
+  })
 })
diff --git a/dev-resources/config.js b/dev-resources/config.js
@@ -1,3 +1,4 @@
+
 module.exports = {
   updateStatusInterval: 1000,
   jina_version: "0.9.18",
@@ -19,7 +20,7 @@ module.exports = {
     },
     messageInterval: 100,
     messageLoops:100,
-    source: "sample-data/sample-output.json"
+    source: "../cypress/fixtures/sample-output.json"
   },
   recorder: {
     url: "http://localhost:5000",

diff --git a/src/components/FlowChart/CommandBar.tsx b/src/components/FlowChart/CommandBar.tsx
@@ -46,10 +46,10 @@ export default function CommandBar({
     <div className="command-bar-container">
       <div className="command-bar">
         <ButtonGroup>
-          <PlayButton onClick={startFlow}>
+          <PlayButton data-name={"playButton"} onClick={startFlow}>
             <img alt="Play" src={Play} />
           </PlayButton>
-          <Button onClick={stopFlow}>
+          <Button data-name={"stopButton"} onClick={stopFlow}>
             <img alt="Stop" src={Stop} />
           </Button>
           <Button onClick={() => exportImage("png")}>

diff --git a/src/components/LogStream/LogItem.tsx b/src/components/LogStream/LogItem.tsx
@@ -25,6 +25,7 @@ const LogItem = memo(
     const { firstCol, secondCol, thirdCol } = columns;
     return (
       <div
+        data-name={`logItem-${index}`}
         className={`log log-${String(
           level
         ).toLowerCase()} px-4 border-bottom py-1`}

diff --git a/src/redux/logStream/logStream.actions.ts b/src/redux/logStream/logStream.actions.ts
@@ -42,7 +42,6 @@ export function initLogStream(
     }
 
     let logsResult = await jinadClient.getLogs(workspace_id, flow_id);
-    logsResult = await jinadClient.getLogs(workspace_id, flow_id);
 
     if (logsResult.status === "error") {
       if (logsResult.message)