Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: debug with segfault handler #5944

Closed
wants to merge 20 commits into from
Closed

test: debug with segfault handler #5944

wants to merge 20 commits into from

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Jun 30, 2023

Goals:

  • resolves #ISSUE-NUMBER

  • ...

  • ...

  • ...

  • ...

  • check and update documentation. See guide and ask the team.

@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase labels Jun 30, 2023
@codecov
Copy link

codecov bot commented Jun 30, 2023 •
edited
Loading

Codecov Report

Merging #5944 (e3f5660) into master (8a0280e) will decrease coverage by 4.60%.
The diff coverage is 54.68%.

@@            Coverage Diff             @@
##           master    #5944      +/-   ##
==========================================
- Coverage   79.29%   74.70%   -4.60%     
==========================================
  Files         144      144              
  Lines       13087    13139      +52     
==========================================
- Hits        10377     9815     -562     
- Misses       2710     3324     +614
Flag Coverage Δ
jina 74.70% <54.68%> (-4.60%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/orchestrate/deployments/__init__.py 77.80% <0.00%> (-4.79%) ⬇️
jina/serve/executors/run.py 43.56% <0.00%> (-0.89%) ⬇️
jina/serve/executors/__init__.py 79.53% <11.76%> (-2.84%) ⬇️
jina/serve/runtimes/asyncio.py 84.14% <57.14%> (-3.83%) ⬇️
jina/__init__.py 56.25% <80.00%> (+2.72%) ⬆️
jina/clients/__init__.py 96.87% <100.00%> (ø)
jina/orchestrate/flow/base.py 79.79% <100.00%> (-10.23%) ⬇️
jina/serve/runtimes/worker/request_handling.py 83.43% <100.00%> (-0.39%) ⬇️

... and 35 files with indirect coverage changes

@JoanFM JoanFM force-pushed the test-with-segfault-handler branch from ce88b09 to be48807 Compare June 30, 2023 13:23
@JoanFM JoanFM closed this Jun 30, 2023
@JoanFM JoanFM reopened this Jun 30, 2023
@github-actions github-actions bot added area/entrypoint This issue/PR affects the entrypoint codebase area/helper This issue/PR affects the helper functionality labels Jun 30, 2023
@JoanFM JoanFM force-pushed the test-with-segfault-handler branch from f262e01 to 63b063e Compare June 30, 2023 15:16
@JoanFM JoanFM closed this Jul 1, 2023
@JoanFM JoanFM reopened this Jul 1, 2023
@JoanFM JoanFM closed this Jul 3, 2023
@JoanFM JoanFM reopened this Jul 3, 2023
@github-actions
Copy link

github-actions bot commented Jul 3, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@JoanFM JoanFM force-pushed the test-with-segfault-handler branch from 732149c to def1abe Compare July 3, 2023 08:28
@github-actions github-actions bot added area/setup This issue/PR affects setting up Jina component/resource and removed component/client labels Jul 3, 2023
@JoanFM
ci: limit pydantic version
eea22d0 
Signed-off-by: Joan Fontanals Martinez <[email protected]>
@JoanFM JoanFM reopened this Jul 5, 2023
@github-actions
Copy link

github-actions bot commented Jul 5, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@JoanFM JoanFM closed this Jul 5, 2023
@JoanFM JoanFM reopened this Jul 5, 2023
@github-actions
Copy link

github-actions bot commented Jul 5, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@JoanFM JoanFM closed this Jul 5, 2023
@JoanFM JoanFM reopened this Jul 5, 2023
@github-actions
Copy link

github-actions bot commented Jul 5, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@JoanFM JoanFM closed this Jul 5, 2023
@JoanFM JoanFM reopened this Jul 5, 2023
@github-actions
Copy link

github-actions bot commented Jul 5, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@JoanFM JoanFM closed this Jul 5, 2023
@JoanFM JoanFM reopened this Jul 5, 2023
@github-actions
Copy link

github-actions bot commented Jul 5, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@JoanFM JoanFM closed this Jul 5, 2023
@JoanFM JoanFM reopened this Jul 5, 2023
@github-actions
Copy link

github-actions bot commented Jul 5, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link

github-actions bot commented Jul 7, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@JoanFM JoanFM closed this Jul 8, 2023
@JoanFM JoanFM reopened this Jul 8, 2023
@github-actions
Copy link

github-actions bot commented Jul 8, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@JoanFM JoanFM closed this Jul 30, 2023
@JoanFM JoanFM deleted the test-with-segfault-handler branch November 13, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanxiao hanxiao Awaiting requested review from hanxiao hanxiao will be requested when the pull request is marked ready for review hanxiao is a code owner

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/entrypoint This issue/PR affects the entrypoint codebase area/helper This issue/PR affects the helper functionality component/client size/M size/S size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoanFM @jina-bot