from Tnthieding/persist IMPORTANT #84
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chankruze
suggested changes
Jun 9, 2021
README.md
Outdated
|
|
||
| An easy-to-use Python library for displaying Windows 10 Toast Notifications which is useful for Windows GUI development. | ||
| Fork of https://github.com/jithurjacob/Windows-10-Toast-Notifications. |
README.md
Outdated
|
|
||
| ## Installation | ||
|
|
||
| ``` | ||
| pip install win10toast | ||
| pip install win10toast-persist |
There was a problem hiding this comment.
This doesn't looks good. Persistence should be a simple configuration rather than changing package name (especially if you want this PR to be merged).
README.md
Outdated
|
|
||
| An easy-to-use Python library for displaying Windows 10 Toast Notifications with support for notifications that persist | ||
| in the notification center. |
README.md
Outdated
|
|
||
|  | ||
|
|
||
| Update original package's interface to support persistent notifications by passing ``duration=None``. |
There was a problem hiding this comment.
It would be better if documented as a new option (i.e. Persistence is now supported using duration=None)
| @@ -66,7 +66,8 @@ def _show_toast(self, title, msg, | |||
| :title: notification title | |||
| :msg: notification message | |||
| :icon_path: path to the .ico file to custom notification | |||
| :duration: delay in seconds before notification self-destruction | |||
| :duration: delay in seconds before notification self-destruction, None for no-self-destruction | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this feature is really needed
please take some time and merge this