Agent should fail on SocketNotFoundException #280 (#281)

If there are no matching candidate because a configuration mistake then the agent should fail.
jitsi · Oct 4, 2024 · d08e5a5 · d08e5a5
1 parent 63cddcd
commit d08e5a5
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/src/main/java/org/ice4j/ice/ConnectivityCheckClient.java b/src/main/java/org/ice4j/ice/ConnectivityCheckClient.java
@@ -344,15 +344,15 @@ protected TransactionID startCheckForPair(
             {
                 logger.trace("checking pair " + candidatePair.toRedactedString() + " tid " + tran);
             }
+
+            return tran;
         }
         catch (NetAccessManager.SocketNotFoundException e)
         {
             logger.info("Could not start connectivity check: " + e.getMessage());
         }
         catch (Exception ex)
         {
-            tran = null;
-
             IceSocketWrapper stunSocket = localCandidate.getStunSocket(null);
 
             if (stunSocket != null)
@@ -376,7 +376,7 @@ protected TransactionID startCheckForPair(
             }
         }
 
-        return tran;
+        return null;
     }
 
     /**
@@ -957,6 +957,10 @@ protected void run()
                         pairToCheck.setStateInProgress(transactionID);
                     }
                 }
+                if (pairToCheck.getState() == CandidatePairState.FAILED)
+                {
+                    updateCheckListAndTimerStates(pairToCheck);
+                }
             }
             else
             {