Randomize consent check interval (follow rfc7675). #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #270 +/- ##
============================================
- Coverage 39.17% 39.06% -0.11%
+ Complexity 1387 1377 -10
============================================
Files 178 178
Lines 12247 12255 +8
Branches 1872 1873 +1
============================================
- Hits 4798 4788 -10
- Misses 6807 6815 +8
- Partials 642 652 +10
... and 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| @@ -129,6 +129,8 @@ public void run() | |||
| private final Map<String, IceMediaStream> mediaStreams | |||
| = new LinkedHashMap<>(); | |||
|
|
|||
| SecureRandom random = new SecureRandom(); | |||
There was a problem hiding this comment.
I don't think this needs SecureRandom; ThreadLocalRandom.current() should be fine.
JonathanLennox
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.