fix validator test

jitsi · Sep 16, 2024 · 91b31b5 · 91b31b5
1 parent 5fe45c5
commit 91b31b5
Showing 1 changed file with 16 additions and 1 deletion.
diff --git a/src/test/validator.ts b/src/test/validator.ts
@@ -28,9 +28,13 @@ describe('Validator', () => {
         getCloudInstances: mock.fn(),
     };
 
+    const shutdownManager = {
+        getShutdownConfirmations: mock.fn((_, instanceIds) => instanceIds.map(() => false)),
+    };
+
     const groupName = 'group';
 
-    const validator = new Validator({ instanceTracker, instanceGroupManager, metricsLoop });
+    const validator = new Validator({ instanceTracker, instanceGroupManager, metricsLoop, shutdownManager });
 
     afterEach(() => {
         context = {
@@ -71,6 +75,17 @@ describe('Validator', () => {
             assert.strictEqual(result, false);
         });
 
+        test('should return false for a group with an instance that has sent back completed webhook', async () => {
+            instanceTracker.trimCurrent.mock.mockImplementationOnce(() => [
+                { instanceId: '1', shutdownComplete: true },
+            ]);
+            metricsLoop.getCloudInstances.mock.mockImplementationOnce(() => []);
+            shutdownManager.getShutdownConfirmations.mock.mockImplementationOnce(() => ['completed']);
+
+            const result = await validator.groupHasActiveInstances(context, groupName);
+            assert.strictEqual(result, false);
+        });
+
         test('should return true for a group with one active and one shutdown instance', async () => {
             instanceTracker.trimCurrent.mock.mockImplementationOnce(() => [
                 { instanceId: '1' },