Skip to content

Commit

Permalink
ci: use node lts (20 as of now) (#954)
Browse files Browse the repository at this point in the history
* ci: really use node lts (20 as of now)
* cleanup README

Remove outdated information, bump to node 20 as well
  • Loading branch information
csett86 authored Mar 10, 2024
1 parent 5ac99bb commit edc4b67
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 26 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: '18'
node-version: '20'
- name: Build it
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Expand All @@ -43,7 +43,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: '18'
node-version: '20'
- name: Prepare for app signing and notarization
env:
MAC_CERT_PASSWORD: ${{ secrets.mac_cert_password }}
Expand Down Expand Up @@ -75,7 +75,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: '18'
node-version: '20'
- name: Build it
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Expand Down
26 changes: 3 additions & 23 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ Download our latest release and you're off to the races!
| -- | -- | -- | -- |
| [Download](https://github.com/jitsi/jitsi-meet-electron/releases/latest/download/jitsi-meet.exe) | [Download](https://github.com/jitsi/jitsi-meet-electron/releases/latest/download/jitsi-meet.dmg) | [x64_64](https://github.com/jitsi/jitsi-meet-electron/releases/latest/download/jitsi-meet-x86_64.AppImage) [arm64](https://github.com/jitsi/jitsi-meet-electron/releases/latest/download/jitsi-meet-arm64.AppImage) | [x86_64](https://github.com/jitsi/jitsi-meet-electron/releases/latest/download/jitsi-meet-amd64.deb) [arm64](https://github.com/jitsi/jitsi-meet-electron/releases/latest/download/jitsi-meet-arm64.deb) |

NOTE: The GNU/Linux builds are 64-bit only.

### Third-Party builds

[<img src="https://dl.flathub.org/assets/badges/flathub-badge-en.svg"
Expand All @@ -46,7 +44,7 @@ If you want to hack on this project, here is how you do it.

#### Installing dependencies

Install Node.js 16 first (or if you use [nvm](https://github.com/nvm-sh/nvm), switch to Node.js 16 by running `nvm use`).
Install Node.js 20 first (or if you use [nvm](https://github.com/nvm-sh/nvm), switch to Node.js 20 by running `nvm use`).

<details><summary>Extra dependencies for Windows</summary>

Expand Down Expand Up @@ -140,7 +138,7 @@ A warning that the app is unsigned will show up upon first install. This is expe

### macOS

On macOS Catalina, a warning will be displayed on first install. The app won't open unless "open" is pressed. This dialog is only shown once.
None

### GNU/Linux

Expand All @@ -150,7 +148,7 @@ On macOS Catalina, a warning will be displayed on first install. The app won't o
* Sharing a full screen is not possible
* When trying to start screensharing under wayland, 2 permission popups will show up. First a pipewire based system selector, then a jitsi internal selector. Select an application window in the first selector and then the same in the jitsi internal selector. Sharing application windows works via this, sharing a full screen unfortunately not.

* On Ubuntu 22.04, the AppImage will fail with a fuse error (as the AppImage uses `libfuse2`, while 22.04 comes with `libfuse3` by default):
* On Ubuntu 22.04 and later, the AppImage will fail with a fuse error (as the AppImage uses `libfuse2`, while 22.04 comes with `libfuse3` by default):

```
dlopen(): error loading libfuse.so.2
Expand All @@ -168,24 +166,6 @@ On macOS Catalina, a warning will be displayed on first install. The app won't o
rm -rf ~/.config/Jitsi\ Meet/
```

<details><summary>NOTE for old GNU/Linux distributions</summary>

You might get the following error:

```
FATAL:nss_util.cc(632)] NSS_VersionCheck("3.26") failed. NSS >= 3.26 is required.
Please upgrade to the latest NSS, and if you still get this error, contact your
distribution maintainer.
```

If you do, please install NSS (example for Debian or Ubuntu):

```bash
sudo apt-get install libnss3
```

</details>

## Translations

The JSON files are for all the strings inside the application, and can be translated [here](/app/i18n/lang).
Expand Down

0 comments on commit edc4b67

Please sign in to comment.