Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hindi translation #886

Closed
wants to merge 4 commits into from
Closed

Add hindi translation #886

wants to merge 4 commits into from

Conversation

shellheim
Copy link
Contributor

Hey!

This PR adds Hindi translation, addressing #883.
Thanks to @saghul for allowing me to contribute to jitsi!
Also sorry for not making a draft PR at first.

@shellheim shellheim marked this pull request as ready for review July 14, 2023 08:31
import i18n from 'i18next';
import { initReactI18next } from 'react-i18next';
import moment from 'moment';
import i18n from "i18next";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do t change the existing style

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am so sorry, wasn't intentional. I was working with neovim and something about how it deals with copy/paste or something else entirely might have caused this, let me fix it.


const languages = {
de: { translation: require('./lang/de.json') },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't change the existing style. Just add your changes with the same style as the surrounding code.

This reverts commit 65fd1b5.
@shellheim shellheim closed this Jul 14, 2023
@shellheim shellheim deleted the add-hindi-translation branch July 14, 2023 13:45
@shellheim
Copy link
Contributor Author

It would be way more simple for me to do it from scratch then actually try to figure out git right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants