dev: get electron-reload back to work #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we lost that somewhere as part of webpack upgrades I guess, and I could not get it to work by configuring webpack differently, but just removing the line in question works and the reload also still works afterwards. Signed-off-by: Christoph Settgast <[email protected]>
saghul
approved these changes
Jan 22, 2024
|
LGTM! Isn't this something to report to electron-reload? |
|
From what I read in upstream electron-reload issues, webpack issues dont seem to be on their priority list. But let me check again :) |
|
See here from the maintainer of electron-reload:
Source: yan-foto/electron-reload#90 (comment) Also electron-reload seems dormant, last commit is from July 2021, so I wont consider upstreaming for now |
|
Makes sense, thanks for giving it a try! |
dom6770
pushed a commit
to SONN-IT/jitsi-meet-sonn
that referenced
this pull request
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we lost that somewhere as part of webpack upgrades I guess,
and I could not get it to work by configuring webpack differently,
but just removing the line in question works and the reload
also still works afterwards.
Signed-off-by: Christoph Settgast [email protected]