Skip to content

Commit

Permalink
fix(receiver constraints): source name not found
Browse files Browse the repository at this point in the history
...when new participant joins.

Repro steps:

1. With p2p disabled and source name signaling enabled.
2. Start a call with 2 tabs.
3. Reload the 2nd tab.
4. The receiver constraints should be updated when the 2nd
   user rejoins. They were not updated, because
   getTrackSourceNameByMediaTypeAndParticipant doesn't have
   the track yet at the time when visibleRemoteParticipants
   are updated. This is fixed by also checking on
   the remote tracks state.
  • Loading branch information
paweldomas authored and jallamsetty1 committed Mar 2, 2022
1 parent c6eccb1 commit 0936a64
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions react/features/video-quality/subscriber.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,12 @@ StateListenerRegistry.register(
_updateReceiverVideoConstraints(store);
}, 100));

StateListenerRegistry.register(
/* selector */ state => state['features/base/tracks'],
/* listener */(remoteTracks, store) => {
_updateReceiverVideoConstraints(store);
});

/**
* Handles the use case when the on-stage participant has changed.
*/
Expand Down

0 comments on commit 0936a64

Please sign in to comment.