Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow running batch submission in-process #7

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tm604
Copy link

@tm604 tm604 commented Nov 22, 2023

When debugging, I found it more useful to have the trace submission run in-process.

This implements a config flag to allow that.

This might not be worth merging, but raising as a PR for visibility in case it's useful to others. Separately, I think "submit asynchronously via Net::Async::HTTP or equivalent" could be a useful feature, so that would be another case where the exporter would want to run in-process.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…round workers
@jjatria
Copy link
Owner

jjatria commented Nov 23, 2023

Yeah, the debugging here can be a little annoying. I find that use Metrics::Any::Adapter 'Stderr' really helps.

That said, I think I agree with this not being something to merge, but rather something to file as potentially useful. Whatever implementation the batch processor uses, it must not block the main process. Whether that's done in an IO::Async::Function or through some other means is I think, up for grabs.

@tm604 tm604 marked this pull request as draft November 23, 2023 16:08
@tm604
Copy link
Author

tm604 commented Nov 23, 2023

I've converted to draft status, to make it clear this isn't pending merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants