fix error <path/a.bib> <path/b.bib> are the same file on open URL #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(org-ref-find-bibliography) can return path from config variable, which may contain symbolic links in the path, when it is compared with (org-ref-get-bibtex-key-and-file), which uses (buffer-file-name) to retrieve a bib file path, it returns an absolute path with all symbolic links resolved. Two different paths pointing to the same file leads to the above error and prevents the body of the let clause from executing. Using the file-truename prevents this error.
|
I don't think this is the right solution, you should probably do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(org-ref-find-bibliography) can return path from config variable, which may contain symbolic links in the path, when it is compared with (org-ref-get-bibtex-key-and-file), which uses (buffer-file-name) to retrieve a bib file path, it returns an absolute path with all symbolic links resolved. Two different paths pointing to the same file leads to the above error and prevents the body of the let clause from executing. Using the file-truename prevents this error.