Add POM code for launching installation #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakoenig
commented
Oct 2, 2024
rakoenig
commented
- Related ticket: https://progress.opensuse.org/issues/163946
rakoenig
force-pushed
the
launch_installation
branch
from
9860eae
to
df13000
Compare
jknphy
reviewed
Oct 3, 2024
| @@ -0,0 +1,14 @@ | |||
| import puppeteer, { type Locator, type Page } from "puppeteer-core"; | |||
There was a problem hiding this comment.
we can drop puppeteer and Locator.
jknphy
reviewed
Oct 3, 2024
| @@ -0,0 +1,14 @@ | |||
| import puppeteer, { type Locator, type Page } from "puppeteer-core"; | |||
|
|
|||
| export class ConfirmInstallationPopup { | |||
|
Big changes from last time you push the code, I will leave it open for a while in case you want to add those page objects in some point (overview and confirm one), but no rush. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.