Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ember modifier v4 #391

Merged
merged 4 commits into from
Aug 22, 2023
Merged

ember modifier v4 #391

merged 4 commits into from
Aug 22, 2023

Conversation

jkusa
Copy link
Owner

@jkusa jkusa commented Mar 8, 2023

resolves #390

@miguelcobain
Copy link
Contributor

Ideally, we would use a macro like this to support both versions of ember-modifiers: https://github.com/DockYard/ember-in-viewport/blob/master/addon/modifiers/in-viewport.js#L14

@MelSumner
Copy link

This would resolve the deprecation message in the console when using the current version of the addon, yes?

(creating a function-based modifier with { eager: true } is deprecated and will be removed at v4.0 [deprecation id: ember-modifier.function-based-options] This will be removed in ember-modifier 4.0.0.)

@jkusa jkusa force-pushed the feature/ember-modifier-v4-depreciations branch from 52bbc05 to ce57d37 Compare August 18, 2023 02:11
@jkusa jkusa force-pushed the feature/ember-modifier-v4-depreciations branch from ce57d37 to 8247e79 Compare August 18, 2023 02:33
@jkusa jkusa merged commit e398557 into main Aug 22, 2023
12 checks passed
@jkusa jkusa deleted the feature/ember-modifier-v4-depreciations branch August 22, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ember-modifier v4 release
4 participants