Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating documentation #50

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Updating documentation #50

wants to merge 9 commits into from

Conversation

waaberi
Copy link

@waaberi waaberi commented Apr 20, 2020

I updated documentation so that people with the requirements.txt problem can fix it. I also modified the page but that isint really important.


```sh-session
$ echo 'eula=true' > eula.txt
$ echo 's3cmd' > requirements.txt
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file is already in the Git repo, why do you need this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's because some people reported problems with this.

Copy link

@mtimoustafa mtimoustafa Oct 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second this - looks like the Python buildpack fails on not finding any expected files. This is before this buildpack is hit, so I'm assuming that's why it doesn't see the requirements.txt file 🤔

When I ran into that issue, manually adding an empty requirements.txt file fixed the issue. Though I'm not familiar with Python, so I don't know what s3cmd is.

@Bryzizzle
Copy link

Personally, I had this issue because I used the Deploy to Heroku button instead of setting up a repo manually. This meant that when I cloned the Heroku's repo back to local, I only have an empty repo. Many (including me) would have the intuition to simply add a text file under the name of "server.properties" to the repo, add the configs they want, and then try and push to remote. This created an issue as Heroku can't build the repo (literally only a text file) and reject the push.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants